Win10: Use GetSystemTimePreciseAsFileTime directly
#121633
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
O-windows
This comment has been minimized.
This comment has been minimized.
|
The Miri subtree was changed cc @rust-lang/miri |
|
This adds |
|
Should Miri be limiting the precision of the other one, if that's what the official implementation does?
|
🤷 Technically it's left unspecified in the Microsoft docs so it could just be the same clock and it's free to change between versions. In practice it has similar limitations to
This can also be adjusted with timeBeginPeriod. But as far as I can tell miri doesn't currently emulate system "ticks" (which are used for all sorts of timers and scheduling) and it would perhaps be odd to implement it only for one function. |
|
r=me on the Miri part |
This is exactly the same as GetSystemTimeAsFileTime except that it promises maximum precision.
|
Squished commits. |
| @@ -345,6 +345,10 @@ extern "system" { | |||
| pub fn GetSystemTimeAsFileTime(lpsystemtimeasfiletime: *mut FILETIME) -> (); | |||
| } | |||
| #[link(name = "kernel32")] | |||
| extern "system" { | |||
There was a problem hiding this comment.
why are these individual extern blocks?
There was a problem hiding this comment.
Because that's what are binding generator generates. The README has a few details about how this file is made.
There was a problem hiding this comment.
Basically it's all made by the windows-bindgen crate.
|
@bors r+ |
bors
added
S-waiting-on-bors
Win10: Use `GetSystemTimePreciseAsFileTime` directly On Windows 10 we can use `GetSystemTimePreciseAsFileTime` directly instead of lazy loading it (with a fallback).
Rollup of 8 pull requests Successful merges: - rust-lang#121148 (Add slice::try_range) - rust-lang#121573 (unix_sigpipe: Add test for SIGPIPE disposition in child processes) - rust-lang#121633 (Win10: Use `GetSystemTimePreciseAsFileTime` directly) - rust-lang#121840 (Expose the Freeze trait again (unstably) and forbid implementing it manually) - rust-lang#121907 (skip sanity check for non-host targets in `check` builds) - rust-lang#122002 (std::threads: revisit stack address calculation on netbsd.) - rust-lang#122108 (Add `target.*.runner` configuration for targets) - rust-lang#122298 (RawVec::into_box: avoid unnecessary intermediate reference) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 9 pull requests Successful merges: - rust-lang#121148 (Add slice::try_range) - rust-lang#121633 (Win10: Use `GetSystemTimePreciseAsFileTime` directly) - rust-lang#121840 (Expose the Freeze trait again (unstably) and forbid implementing it manually) - rust-lang#121907 (skip sanity check for non-host targets in `check` builds) - rust-lang#122002 (std::threads: revisit stack address calculation on netbsd.) - rust-lang#122108 (Add `target.*.runner` configuration for targets) - rust-lang#122298 (RawVec::into_box: avoid unnecessary intermediate reference) - rust-lang#122315 (Allow multiple `impl Into<{D,Subd}iagMessage>` parameters in a function.) - rust-lang#122326 (Optimize `process_heap_alloc`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#121633 - ChrisDenton:precise, r=Nilstrieb Win10: Use `GetSystemTimePreciseAsFileTime` directly On Windows 10 we can use `GetSystemTimePreciseAsFileTime` directly instead of lazy loading it (with a fallback).
On Windows 10 we can use
GetSystemTimePreciseAsFileTimedirectly instead of lazy loading it (with a fallback).